War2 graphics for Win Vista/7/8/8.1/10/2012 fixed

[aqrit]

 

Could you write some pseudo code or even C++ code for color_convert()

Code: [Select]

void __cdecl
color_convert( BYTE* src, RGBQUAD* pal, DWORD* dst, DWORD cnt )
{
do{
dst[0] = pal[src[0]];
dst[1] = pal[src[1]];
dst[2] = pal[src[2]];
dst[3] = pal[src[3]];
dst = &dst[4];
src = &src[4];
} while( --cnt );
}


I'm still interested in moving code onto multiple threads.

don't ... the next item on my todo list is:

use d3d shader to color convert.

[aqrit]

http://www.bitpatch.com/downloads/war2_ddraw_test4.zip
 
This *barely tested* build should have a nice speed up ( not measured ) from using a pixel shader.
It has some additional system requirements but I'm guessing everyone should still be able to run it.

[iL]

http://www.bitpatch.com/downloads/war2_ddraw_test4.zip
 
This *barely tested* build should have a nice speed up ( not measured ) from using a pixel shader.
It has some additional system requirements but I'm guessing everyone should still be able to run it.

I have no idea what related to starcraft you made with that version, but looks like prtscr in chat is fixed for war2!
Just checked in win8.1 and winxp 64.

I missed if you announced such behaviour, but did you really fixed that? So, will working prtscr be inherited in future versions?

UPD: i see, this commit: https://github.com/aqrit/war2_ddraw/commit/59cdc85f8c3f52d8dd0b93cfa09116f75bb54108
just the flag if prtscr is pressed.
So, my feedback is it's working perfectly.

[EviL~Ryu]

So is there a new version of patch I should be using?


Sent from my Motorola DynaTAC 8000X using Tapatalk

[xboi209]

This looks really smooth to me. Someone else asked if it were possible to somehow only have the code executed when not in-game since there aren't any graphical bugs in-game?

[iL]

I got another unpleasant bug with test4:
Situation:
- war2 is running with ddraw.dll
- several more applications also running
- i alt-tab out of war2 to my desktop (so, war2 window is minimized)

then i try to click to any other application in my taskbar and it temporary switches into war2 windows, that causes turn to black screen, then back and then opens window of application i clicked to.
The situation happens only if i click to the task bar.
If i use alt-tab instead or switching cascaded windows on my desktop, it never activates war2 screen.

Checked on winxp x64.
Never happened if delete ddraw.dll.

[xboi209]

I got another unpleasant bug with test4:
Situation:
- war2 is running with ddraw.dll
- several more applications also running
- i alt-tab out of war2 to my desktop (so, war2 window is minimized)

then i try to click to any other application in my taskbar and it temporary switches into war2 windows, that causes turn to black screen, then back and then opens window of application i clicked to.
The situation happens only if i click to the task bar.
If i use alt-tab instead or switching cascaded windows on my desktop, it never activates war2 screen.

Checked on winxp x64.
Never happened if delete ddraw.dll.

This doesn't happen on Windows 10 using BW.........but why are you even testing with Windows XP?

[shesycompany]

sc1 works perfectly!

[Delete mine too]

Dude this guy is bad ass!

[Certified MENSA Genius Brain (smart)]

I got another unpleasant bug with test4:
Situation:
- war2 is running with ddraw.dll
- several more applications also running
- i alt-tab out of war2 to my desktop (so, war2 window is minimized)

then i try to click to any other application in my taskbar and it temporary switches into war2 windows, that causes turn to black screen, then back and then opens window of application i clicked to.
The situation happens only if i click to the task bar.
If i use alt-tab instead or switching cascaded windows on my desktop, it never activates war2 screen.

Checked on winxp x64.
Never happened if delete ddraw.dll.

This doesn't happen on Windows 10 using BW.........but why are you even testing with Windows XP?

true, windows xp doesnt need any version edits to run properly

[EviL~Ryu]

People still use Windows XP? Who and why? Lol


Sent from my Motorola DynaTAC 8000X using Tapatalk

[aqrit]

only have the code executed when not in-game since there aren't any graphical bugs in-game?

This would be pointless on Vista and Win7. On Win8 and Win10 it could be be done... but is there a confirmed reason to do so?

set_palette function... from a data set of 13,911 calls.

I might need to clean-up this function if it is getting called in-game.

XP alt+tab

that is fairly strange behavior... does it happen only while on the bnet screens or does it also happen when alt-tabbing out from single player campaign?

ClearType fonts (x-post)

I haven't tested but...
enabling anti-aliased fonts probably risks breaking the built-in screenshots on the bnet screens, because there will be more than 256 colors on screen and gdi will probably screw up the color conversion.

[iL]

but why are you even testing with Windows XP?

I test everything related to war2 on every version since XP. Some people even asked me why loader is not woking on win 95...
That behaviour means that something goes wrong with that dll. At least need to understand what it is and why it causes such behaviour for winxp and if that can cause something in win7-8-10...

true, windows xp doesnt need any version edits to run properly

XP sometimes also had a problem with palette in war2. (Not sure if it was some driver or anything else). Also not sure if this dll fixes that for winxp, but i think it should.

that is fairly strange behavior... does it happen only while on the bnet screens or does it also happen when alt-tabbing out from single player campaign?

It happens even on the main menu screen.
I also checked on some more systems: never happened on win 8.1, but the same bug on different computer with clean winxp x32 (with last updates).
Looks like when i click the taskbar button i activate one of war2 layer windows. It changes the screen resolution (turns screen to black) and then turns it back to activated application. Also if i close that active application, it switches to war2 screen.

Appeared in test4, didn't happen for test3.

[xboi209]

Quote (selected)
only have the code executed when not in-game since there aren't any graphical bugs in-game?
This would be pointless on Vista and Win7. On Win8 and Win10 it could be be done... but is there a confirmed reason to do so?

It'd guarantee no additional lag from this DLL(even though from my testing, your latest update seems flawless to me).

Quote (selected)
set_palette function... from a data set of 13,911 calls.
I might need to clean-up this function if it is getting called in-game.

The calls were recorded from the time when the game's process is started until a minute or so after playing an actual game so I don't know how many, if any of those calls are being called in-game.

Quote from: xboi209 on January 02, 2016, 06:08:15 PM
but why are you even testing with Windows XP?
I test everything related to war2 on every version since XP. Some people even asked me why loader is not woking on win 95...
That behaviour means that something goes wrong with that dll. At least need to understand what it is and why it causes such behaviour for winxp and if that can cause something in win7-8-10...

Well the DLL isn't intended for anything older than Windows Vista so it makes completely no sense to include it on Windows XP computers because the best it can do is slow down the game, even if not very noticeable.

[Certified MENSA Genius Brain (smart)]

I have never ever had a problem with War2 on WinXP on this computer, but after getting the latest requested update, I do.

After having run War2 properly for the last 10 years on this machine, I can't now.  I don't know what you did but for WinXP it was bad.  Please don't do this to WinXP computers.